Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added photocatalytic activity #527

Closed
wants to merge 6 commits into from
Closed

Added photocatalytic activity #527

wants to merge 6 commits into from

Conversation

jmillanacosta
Copy link
Member

Solves #510

@jmillanacosta jmillanacosta requested a review from egonw February 16, 2024 10:47
@jmillanacosta jmillanacosta self-assigned this Feb 16, 2024
@jmillanacosta jmillanacosta linked an issue Feb 16, 2024 that may be closed by this pull request
[TERM REQUEST] Photocatalytic activity #510
Open
egonw
egonw requested changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@egonw egonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how added the subclassing/selecting here, but GO_0003824 seems to specifically refer to biochemical reactions, and "at physiological temperatures" even. I think we need a different class here. What do you think?

@jmillanacosta
Copy link
Member Author

Not sure how added the subclassing/selecting here, but GO_0003824 seems to specifically refer to biochemical reactions, and "at physiological temperatures" even. I think we need a different class here. What do you think?

Correct, need to evaluate

jmillanacosta and others added 3 commits February 16, 2024 15:35
@jmillanacosta
Corrected subClassOf 'photocatalytic activity'
ae29b56 
Corrected subClassOf 'photocatalytic activity' to reflect wider meaning (not necessarily biochemical)
@jmillanacosta
Merge branch 'master' into 510-term-request-photocatalytic-activity
80d7bf3
@jmillanacosta
Fixed malformed xml
32da592
jmillanacosta
jmillanacosta commented Feb 16, 2024
View reviewed changes
internal-dev/chebi-ext.owl
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subClassOf function (solves problem with GO - catalytic activity definition)

@jmillanacosta jmillanacosta requested a review from egonw February 16, 2024 14:54
auto-merge was automatically disabled May 6, 2024 11:01

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egonw egonw Awaiting requested review from egonw

Assignees

@jmillanacosta jmillanacosta

Labels
SbD4Nano
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TERM REQUEST] Photocatalytic activity
2 participants
@jmillanacosta @egonw