Skip to content

Commit

Permalink
target/riscv: remove riscv_hart_count()
Browse files Browse the repository at this point in the history
Change-Id: Iac9021af59ba8dba2cfb6b9dd15eebc98fe42a08
Signed-off-by: Evgeniy Naydanov <[email protected]>
  • Loading branch information
en-sc committed Jan 10, 2024
1 parent 6a61446 commit 7f68772
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 26 deletions.
11 changes: 1 addition & 10 deletions src/target/riscv/riscv-013.c
Original file line number Diff line number Diff line change
Expand Up @@ -2150,8 +2150,7 @@ static int examine(struct target *target)
/* Some regression suites rely on seeing 'Examined RISC-V core' to know
* when they can connect with gdb/telnet.
* We will need to update those suites if we want to change that text. */
LOG_TARGET_INFO(target, "Examined RISC-V core; found %d harts",
riscv_count_harts(target));
LOG_TARGET_INFO(target, "Examined RISC-V core");
LOG_TARGET_INFO(target, " XLEN=%d, misa=0x%" PRIx64, r->xlen, r->misa);
return ERROR_OK;
}
Expand Down Expand Up @@ -2203,13 +2202,6 @@ static int riscv013_authdata_write(struct target *target, uint32_t value, unsign
return ERROR_OK;
}

static int riscv013_hart_count(struct target *target)
{
dm013_info_t *dm = get_dm(target);
assert(dm);
return dm->hart_count;
}

/* Try to find out the widest memory access size depending on the selected memory access methods. */
static unsigned riscv013_data_bits(struct target *target)
{
Expand Down Expand Up @@ -2772,7 +2764,6 @@ static int init_target(struct command_context *cmd_ctx,
generic_info->dm_read = &dm_read;
generic_info->dm_write = &dm_write;
generic_info->read_memory = read_memory;
generic_info->hart_count = &riscv013_hart_count;
generic_info->data_bits = &riscv013_data_bits;
generic_info->print_info = &riscv013_print_info;

Expand Down
10 changes: 0 additions & 10 deletions src/target/riscv/riscv.c
Original file line number Diff line number Diff line change
Expand Up @@ -5067,16 +5067,6 @@ static void riscv_invalidate_register_cache(struct target *target)
}


unsigned int riscv_count_harts(struct target *target)
{
if (!target)
return 1;
RISCV_INFO(r);
if (!r || !r->hart_count)
return 1;
return r->hart_count(target);
}

/**
* If write is true:
* return true iff we are guaranteed that the register will contain exactly
Expand Down
6 changes: 0 additions & 6 deletions src/target/riscv/riscv.h
Original file line number Diff line number Diff line change
Expand Up @@ -253,8 +253,6 @@ struct riscv_info {
int (*read_memory)(struct target *target, target_addr_t address,
uint32_t size, uint32_t count, uint8_t *buffer, uint32_t increment);

/* How many harts are attached to the DM that this target is attached to? */
int (*hart_count)(struct target *target);
unsigned (*data_bits)(struct target *target);

COMMAND_HELPER((*print_info), struct target *target);
Expand Down Expand Up @@ -397,10 +395,6 @@ unsigned riscv_xlen(const struct target *target);
/*** Support functions for the RISC-V 'RTOS', which provides multihart support
* without requiring multiple targets. */

/* Lists the number of harts in the system, which are assumed to be
* consecutive and start with mhartid=0. */
unsigned int riscv_count_harts(struct target *target);

/**
* Set the register value. For cacheable registers, only the cache is updated
* (write-back mode).
Expand Down

0 comments on commit 7f68772

Please sign in to comment.