Fix test cases for Stretch3 movement in Bathing Env #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoruCathy
requested changes
Oct 8, 2024
There was a problem hiding this comment.
For deploy, revert to pytest tests/
There was a problem hiding this comment.
name the player "BathingPlayer" for consistency
There was a problem hiding this comment.
Where does the number 3.49066 come from? Just curious
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes faulty degree / radian usages and coordinate system mix-ups in
test_bathing_env.py.Test Plan:
Tests may fail since it seems like the robot is not actually behaving as expected in #109. At least,
test_angle_functions.pyshould certainly pass. Besides that, code review is needed to ensure the test cases are actually testing correct behavior.