Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urlBuilder.buildMongoConnString doesn't perform encodeURIComponent #55

Open
azisso opened this issue Mar 14, 2018 · 0 comments
Open

urlBuilder.buildMongoConnString doesn't perform encodeURIComponent #55

azisso opened this issue Mar 14, 2018 · 0 comments

Comments

@azisso
Copy link

azisso commented Mar 14, 2018

Hey,
The described function takes input parameters like username and password and passes them to the underlying MongoDB driver.
This can cause issues with specific values like a password containing a comma (,), and others as can be seen here:
https://jira.mongodb.org/browse/NODE-809

Also, a better solution would be to leave the auth parameters (user and password) in the options parameter passed into the driver, instead of adding them to the beginning of url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant