Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated addon queue #56

Open
adam-knights opened this issue Oct 13, 2016 · 3 comments
Open

Updated addon queue #56

adam-knights opened this issue Oct 13, 2016 · 3 comments

Comments

@adam-knights
Copy link

We got a really fast initial review of https://emberobserver.com/addons/ember-material-design-datepicker, but then none since. I imagine this is because there is a large backlog? A couple questions and suggestions about the 'queue'.

  1. When we publish a second update, before you have reviewed the first update, do we maintain our place in the queue, or get put to the bottom again?

  2. Could we get visibility of the queue in some way to see where addon reviews are?

@sedouard
Copy link

+1 On this. Seems like reviews are all manual and nobody's getting around to doing them. Is there no automated, pre-review, score?

@kategengler
Copy link
Member

Reviews are not entirely manual, only two questions are. Most addons should be reviewed within 2 days of publishing, re-reviews within a week, if not, please use the link on the addon page to 'Submit a correction', sometimes we miss an addon on accident.

To answer the questions:
Second updates get put to the bottom again, but the queue is emptied very often so this should not be an issue.
I will think about a visible queue. I'm also considering reducing re-reviews of existing addons to only minor & major version bumps.

@tomwayson
Copy link

visibility into the queue, or at least documentation of how it works would be helpful. All of our addons still appear as WIP b/c they were initially in private repos, but we've since open sourced most of them and had a few minor version releases.

For example, see: https://emberobserver.com/addons/ember-arcgis-portal-services
If you view that on npm you will see that the source is available at: https://github.com/Esri/ember-arcgis-portal-services

It shows last reviewed on August 26th 2017 for version 0.21.1 but we're currently on 0.29.0. I can't find any information on the site about when it will be reviewed next, but 6 months seems like a long time.

One thing to note is that the way we open sourced this was to transfer ownership of the repository from one org to another - in other words the repository field package.json changed from the private https://github.com/ArcGIS/ember-arcgis-portal-services to https://github.com/Esri/ember-arcgis-portal-services. Maybe this is only a problem for addons that start in private repos and get moved to public ones?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants