Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redesign] Add content for a Component Example on the hompage #364

Open
3 tasks
mansona opened this issue Jul 25, 2019 · 3 comments
Open
3 tasks

[redesign] Add content for a Component Example on the hompage #364

mansona opened this issue Jul 25, 2019 · 3 comments
Assignees
Labels

Comments

@mansona
Copy link
Member

mansona commented Jul 25, 2019

If this is your first time tackling an issue that is part of the redesign project please read all the Notes section at the bottom of this issue before claiming it and starting to work on it

Screenshot 2019-07-25 at 10 55 26

Add the content for the Component example on the homepage. You only need to add one toy example as the content of the examples is still being discussed

Blockers (ember-styleguide)

  • Create documentation for code samples
  • Create component that can use Prism to highlight code

Todo

  • Use code sample component on the homepage

useful documentation

(add when styleguide has been updated)


Notes (important)

This issue is part of the Ember Website Redesign RFC and if you are not familiar with the RFC you should read it and look at the example landing page before attempting this issue.

When creating your PR you should target the redesign-rfc branch. This way when your PR is merged it will not update master it will instead update the long-lived branch that is tracking the website redesign work.

This issue is strictly to add the content for a section of the homepage. All styles should be provided by the ember-styleguide and we should not be adding styles to the ember-website for any reason. To see the documentation of the styleguide you can go to https://deploy-preview-145--ember-styleguide.netlify.com/

If you find that there is documentation or implementation lacking in the ember-styleguide to adequately tackle this issue then part of the deliverable of this issue is to document what is missing 👍 this will facilitate improvements in the ember-styleguide that will allow you to complete your work and get your PR merged.

@mansona mansona changed the title Add content for a Component Example on the hompage [redesign] Add content for a Component Example on the hompage Jul 25, 2019
@mansona
Copy link
Member Author

mansona commented Aug 8, 2019

This has been deferred until we have the right content to include in the examples. It is unlikely to be in the first phase of the project

@MelSumner MelSumner self-assigned this Aug 23, 2019
@stale
Copy link

stale bot commented Dec 21, 2019

This issue has been automatically marked stale. If this issue is something that still needs work, please add a comment and it will remain open, otherwise it will close in 7 days. You are welcome to open a new issue if you miss the window. Thanks!

@stale stale bot added the stale label Dec 21, 2019
@stale stale bot closed this as completed Dec 28, 2019
@mansona mansona reopened this Jan 6, 2020
@stale stale bot removed the stale label Jan 6, 2020
@stale
Copy link

stale bot commented May 5, 2020

This issue has been automatically marked stale. If this issue is something that still needs work, please add a comment and it will remain open, otherwise it will close in 7 days. You are welcome to open a new issue if you miss the window. Thanks!

@stale stale bot added the stale label May 5, 2020
@mansona mansona added the pinned label May 5, 2020
@stale stale bot removed the stale label May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants