New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type: 'git-commit' doesn't work from git submodule #21

Open

mrloop opened this issue Oct 29, 2015 · 1 comment

Labels

bug

mrloop commented Oct 29, 2015

Related to rwjblue/git-repo-info#11

From a git submodule I get the following error

+- prepare
|  |
|  +- revision-data
|    - creating revision data using `git-commit`
|
+- didFail
TypeError: Cannot read property 'slice' of null
TypeError: Cannot read property 'slice' of null
  at CoreObject.module.exports.CoreObject.extend.generate (/home/ewan/projects/questionr/main/node_modules/ember-cli-deploy-revision-data/lib/data-generators/git-commit.js:14:23)

As a workaround in deploy.js I'm using

var exec = require('child_process').execSync;

....

redis: {
  revisionKey: function(){
    return exec('git rev-parse --short --verify HEAD').toString().replace('\n',''); 
  }
}

Contributor

jrowlingson commented Oct 29, 2015

@achambers I believe the PR above should resolve this.

ghedamat added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment