From 81042a30b910e61cc6c5daa54a8ba9aedadbbe68 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Fri, 2 Oct 2020 13:15:38 +0000 Subject: [PATCH 1/2] Bump eslint-plugin-ember from 7.13.0 to 8.14.0 Bumps [eslint-plugin-ember](https://github.com/ember-cli/eslint-plugin-ember) from 7.13.0 to 8.14.0. - [Release notes](https://github.com/ember-cli/eslint-plugin-ember/releases) - [Changelog](https://github.com/ember-cli/eslint-plugin-ember/blob/master/CHANGELOG.md) - [Commits](https://github.com/ember-cli/eslint-plugin-ember/compare/v7.13.0...v8.14.0) Signed-off-by: dependabot-preview[bot] --- package-lock.json | 23 +++++++++++++++++++---- package.json | 2 +- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/package-lock.json b/package-lock.json index 7f878b0..dfe0230 100644 --- a/package-lock.json +++ b/package-lock.json @@ -14257,14 +14257,23 @@ } }, "eslint-plugin-ember": { - "version": "7.13.0", - "resolved": "https://registry.npmjs.org/eslint-plugin-ember/-/eslint-plugin-ember-7.13.0.tgz", - "integrity": "sha512-qIbw4uP0qUJoiWF4+7MTJWqwEN86RGmBNId0cwSoHoVNWtcw50R1ajYgxM1Q5FVUdoisVeSl9lKVRh5zkDFl+g==", + "version": "8.14.0", + "resolved": "https://registry.npmjs.org/eslint-plugin-ember/-/eslint-plugin-ember-8.14.0.tgz", + "integrity": "sha512-PQhR58omMAZzcJOB8GLWzL6l/vjRZ2Uo1eohxOmgPUyeBkHfZAMlvK+OSeneMLIr4azLQ4GISkklwv6lxb8qnw==", "dev": true, "requires": { "@ember-data/rfc395-data": "^0.0.4", - "ember-rfc176-data": "^0.3.12", + "ember-rfc176-data": "^0.3.15", + "lodash.kebabcase": "^4.1.1", "snake-case": "^3.0.3" + }, + "dependencies": { + "ember-rfc176-data": { + "version": "0.3.16", + "resolved": "https://registry.npmjs.org/ember-rfc176-data/-/ember-rfc176-data-0.3.16.tgz", + "integrity": "sha512-IYAzffS90r2ybAcx8c2qprYfkxa70G+/UPkxMN1hw55DU5S2aLOX6v3umKDZItoRhrvZMCnzwsdfKSrKdC9Wbg==", + "dev": true + } } }, "eslint-plugin-es": { @@ -17811,6 +17820,12 @@ "integrity": "sha1-eeTriMNqgSKvhvhEqpvNhRtfu1U=", "dev": true }, + "lodash.kebabcase": { + "version": "4.1.1", + "resolved": "https://registry.npmjs.org/lodash.kebabcase/-/lodash.kebabcase-4.1.1.tgz", + "integrity": "sha1-hImxyw0p/4gZXM7KRI/21swpXDY=", + "dev": true + }, "lodash.keys": { "version": "3.1.2", "resolved": "https://registry.npmjs.org/lodash.keys/-/lodash.keys-3.1.2.tgz", diff --git a/package.json b/package.json index 5a845e0..05cf34d 100644 --- a/package.json +++ b/package.json @@ -57,7 +57,7 @@ "ember-source": "~3.16.0", "ember-source-channel-url": "^3.0.0", "ember-try": "^1.4.0", - "eslint-plugin-ember": "^7.7.2", + "eslint-plugin-ember": "^8.14.0", "eslint-plugin-node": "^11.0.0", "loader.js": "^4.7.0", "qunit-dom": "^1.0.0", From f993aa68d3fadc6f8a3fe48768e1748ca55d8e5b Mon Sep 17 00:00:00 2001 From: Benjamin JEGARD Date: Fri, 2 Oct 2020 16:09:43 +0200 Subject: [PATCH 2/2] Fix eslint error --- addon/components/a11y-landmark.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/addon/components/a11y-landmark.js b/addon/components/a11y-landmark.js index 50ee12f..2c61007 100644 --- a/addon/components/a11y-landmark.js +++ b/addon/components/a11y-landmark.js @@ -68,8 +68,8 @@ export default Component.extend({ * since nothing is going to be the direct child of the body in an Ember app, we don't have to check for that. */ ariaRole: computed('tagName', 'landmarkRole', function() { - const landmark = this.get('tagName'); - const landmarkRole = this.get('landmarkRole'); + const landmark = this.tagName; + const landmarkRole = this.landmarkRole; if (landmark && landmarkRole) { if (landmark === 'form' && landmarkRole === 'search') {