Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align readme with current mteb #1493

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Conversation

Samoed
Copy link
Collaborator

@Samoed Samoed commented Nov 24, 2024

Checklist

  • Run tests locally to make sure nothing is broken using make test.
  • Run the formatter to format the code using make lint.

The current README is a bit misleading and causing issues for newcomers. See #1490 and #1491 for reference.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Samoed
Copy link
Collaborator Author

Samoed commented Nov 26, 2024

I made model check as in mieb branch. Will be fixed after #1499

Copy link
Contributor

@KennethEnevoldsen KennethEnevoldsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - pull from main should do

@KennethEnevoldsen
Copy link
Contributor

This seems ready to merge (for future reference feel free to just merge once you have gotten an approved review)

@KennethEnevoldsen KennethEnevoldsen merged commit 942f212 into main Nov 27, 2024
10 checks passed
@KennethEnevoldsen KennethEnevoldsen deleted the update_custommodel_readme branch November 27, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants