Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3758
This commit fixes a race condition in the
embassy-rp
time driver IRQ that causes the time driver to lock up when an alarm is scheduled that expires before the IRQ finishes.I convinced myself that this fix worked by first changing the IRQ to be
This change made the corner case much easier to hit, and I was able to reproduce the issue in ~30 seconds rather than every 15 minutes or so. By moving the IRQ clear to the start of the ISR, I was able to stop the hang from happening altogether.