(void-variable hasnotes)

[LorenRiccie]

Hi @myshevchuk ,

Tried the configuration you mentionned in #646, and get stuck with this error, after citar-insert-citation

Debugger entered--Lisp error: (void-variable hasnotes) (gethash citekey hasnotes)

Any idea?

Whatever the new Citar API will look like, ORB will support it.

FYI, I'll be tagging 1.0 in the coming days, and then bumping the doom biblio module.

I will post this on the wiki, I think, for folks who want to continue to use ORB:

(citar-register-notes-source
 'orb-citar-source
 (list :name "Org-Roam Notes"
        :category 'org-roam-node
        :items #'citar-org-roam--get-candidates
        :hasitems #'citar-org-roam-has-notes
        :open #'citar-org-roam-open-note
        :create #'orb-citar-edit-note
        :annotate #'citar-org-roam--annotate))

(setq citar-notes-source 'orb-citar-source)

This relies on https://github.com/emacs-citar/citar-org-roam.

Originally posted by @bdarcus in #646 (comment)

[bdarcus]

Are you sure you're on very latest version of Citar; 1.0 or newer?

In any case, this error isn't related to org-roam or ORB.

Also, please change the title.

[LorenRiccie]

emacs 28.1 and last citar version I think, 20220809.2249.
Isn't it related to citar-org-roam ?

[bdarcus]

I think only indirectly.

I'll check a thing or two when in front of a computer.

[bdarcus]

I'll check a thing or two when in front of a computer.

So I can't reproduce the error.

The error itself does appear to be coming from this line of citar-org-roam.

Do you have citar-org-roam-mode activated?

(use-package citar-org-roam
  :after citar org-roam
  :no-require
  :config (citar-org-roam-mode))

EDIT: actually, you probably don't want/need the:config line; but you do need to make sure that the file is loaded.