Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify open functions, APIs #511

Closed
bdarcus opened this issue Dec 28, 2021 · 1 comment
Closed

Clarify open functions, APIs #511

bdarcus opened this issue Dec 28, 2021 · 1 comment

Comments

@bdarcus
Copy link
Contributor

bdarcus commented Dec 28, 2021

As followup to #509 discussion, we need to settle what we want to do with these functions longer term:

  1. citar-open
  2. citar-open-library-file
  3. citar-open-link
  4. etc

Specifically, there are two changes that should impact our answers here:

  1. embark-act-all
  2. use of cosult-multi in citar-open in particular (see Add groups to citar-open functions #491)

No rush on this; I just put it here because we do need to settle the plan. I also need to think about it more.

I will say my preference is to keep the code as simple as possible to maintain and build on, and that it's currently too complicated in places in my view.

cc @roshanshariff @localauthor

@bdarcus bdarcus mentioned this issue May 3, 2022
@bdarcus
Copy link
Contributor Author

bdarcus commented Jul 10, 2022

Closed via #634

@bdarcus bdarcus closed this as completed Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant