Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Error Notification uses the theme's primary color instead of a constant red #246

Open
doloczki opened this issue Jun 4, 2019 · 1 comment

Comments

@doloczki
Copy link

doloczki commented Jun 4, 2019

It would be nice if the Error Notification would use a constant red color for it's border (just like the warning and success notifications which use yellow and green). In my application I had to change the primary color in the theme and it effected the notification's border color.

@chrisheninger
Copy link
Contributor

👋 Hi Doloczki–

Excellent feedback– looking at the component I can see that we're using primary 800 for the error messaging on that component– https://github.com/elm-street-technology/elevate-ui/blob/master/src/GlobalNotification/Notification.js#L59

Checking out the color palette– it looks like we have a section for elevateRed (which happens to be the primary color for Elevate apps) that we could use for the error messaging. This will fix issues like you're running into where the primary colors might have been substituted and might not fit for the error messaging. https://www.elevate-ui.com/color-palette

If you'd like to submit a PR that updates the Notification component to use theme.colors.elevateRed["800"] instead of primary, I'm sure it would be an accepted change. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants