Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to add other users? #13

Closed
Ronaldvr opened this issue Nov 10, 2023 · 10 comments · Fixed by #340
Closed

How to add other users? #13

Ronaldvr opened this issue Nov 10, 2023 · 10 comments · Fixed by #340
Assignees
Labels
enhancement New feature or request

Comments

@Ronaldvr
Copy link

Adding household members implies they could also be users this does not seem to be the case?
It would in a sense also open the door for gift subscriptions, i.e. subscriptions for 1 person paid for by another

@nebbishOne
Copy link

I just submitted issue #14 with the same basic question. I've looked into the code and the "households" table just has a Name field right now, so yeah, it seems those names can't login. I think the only time you can create a new user is when there are no other users defined yet and so just 1 login possible. Correct me if I'm wrong, of course, @ellite .

@ellite
Copy link
Owner

ellite commented Nov 10, 2023

Hi.
For the moment only on account can login.
The idea with the household is that everyone can login with the same account and add the subscriptions for their household using the household member.
Implementing multi login will require a total redesign of the database, so, it will not be done for now, until I fix all the issues. Sorry.

@ellite ellite added the enhancement New feature or request label Nov 10, 2023
@ellite ellite self-assigned this Nov 10, 2023
@benjick
Copy link

benjick commented Nov 11, 2023

Maybe an option to disable login would be more viable? Lots of people running their own auth anyways

@Ronaldvr
Copy link
Author

This weekend I thought of an 'interim' solution: Just create an extra field, "Beneficiary" with the same choices as Paid by . Then you do not need additional logins but can distinguish between who pays for a subscription, and for whom it actually is, so I can log my gift subscription for a game pass for instance

snyssen added a commit to snyssen/infra-snyssen.be that referenced this issue Mar 26, 2024
There are a few issues on the project regarding authentication:
- ellite/Wallos#13
- ellite/Wallos#14
- ellite/Wallos#32
and looking through the code made me realize it was probably not the most secure, so even though I can't disable its own authentication, I prefer to put Authelia in front for extra safety
@carsaig
Copy link

carsaig commented May 21, 2024

huh, I was a little disappointed to see it only supports one user :-( I'm aware of the implications adding multi-user. Still - that makes perfect sense as people have their own subscriptions nowadays. Throwing everything into one pot is not useful. Even in a two-person household. However - good work. Keep going!

@ellite
Copy link
Owner

ellite commented May 21, 2024

It's being worked on.
But it's taking a s*** load of time.

It's not an easy migration because of the dynamic currencies, categories and paying methods.

There's a new admin page and every new string has to be translated in 17 languages.

Progress:

  • Admin page is almost ready
  • DB Migration script is done
  • 100% of the queries on the Ajax endpoints have been changed to use the new DB schema
  • I estimate around 90% of the queries used on Dashboard, Statistics and Settings page have been changed to use the new DB schema
  • All the new strings have been translated

Missing:

  • Remaining 10% of queries
  • All the endpoints for the Admin page (whether registrations are open, user management, email settings for password reset)
  • Cronjobs should run for all users
  • User registration
  • Password reset
  • Something else I'm probably forgetting
  • Lots of testing

But yeah, might take a while.

Regards.

@carsaig
Copy link

carsaig commented May 21, 2024

Aye....good man! Keep it up :-) Take your time.

@ellite
Copy link
Owner

ellite commented May 21, 2024

This is the new Admin page:
adminpage

@ellite ellite linked a pull request May 26, 2024 that will close this issue
@ellite
Copy link
Owner

ellite commented May 26, 2024

Version 2.0 with user account creation is now live.

@Nec83
Copy link

Nec83 commented May 29, 2024

@ellite Great work and thank you for this feature addition!

Just to check, what is the intention with having multiple users being able to register? From the looks of things, they get their own logins and can add subscriptions but can't see or view any subscriptions assigned to them for notification so this is a pretty blind way for them to try and manage subscriptions assigned to them?

Any way to potentially expand on this feature to make them view the subscriptions when they're added to the same Household or at the very least the ones assigned to them for notifications?

Thank you for your efforts and making this great app!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants