Fix oversize padding on captioned images/videos

[frebib]

Content

Use consistent padding with the InReplyToView for the media, and consistent caption padding with other textual messages.

Note: The screenshots look kinda broken, but it looks like they were broken before my changes. This renders fine in-app and I've been using this patch for several weeks already.

Motivation and context

It bothered me that the padding around captioned images vs reply blocks was different. Judging by element-hq/element-x-ios#3436 it looks like the behaviour in this PR is more aligned with what iOS does too.

This change does also suffer from the issue outlined in element-hq/element-x-ios#3436 too although I'm not sure that's a new problem.

Screenshots / GIFs

Before	After

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

• Your branch should be based on origin/develop, at least when it was created.
• The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
• The test pass locally running ./gradlew test.
• The code quality check suite pass locally running ./gradlew runQualityChecks.
• If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

[codecov]

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.04%. Comparing base (870ae5f) to head (012e15e).
Report is 3 commits behind head on develop.

Files with missing lines	Patch %	Lines
...s/impl/timeline/components/TimelineItemEventRow.kt	77.77%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3732      +/-   ##
===========================================
- Coverage    83.06%   83.04%   -0.02%     
===========================================
  Files         1754     1755       +1     
  Lines        44022    44032      +10     
  Branches      5144     5148       +4     
===========================================
+ Hits         36565    36566       +1     
- Misses        5635     5638       +3     
- Partials      1822     1828       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[frebib]

Nice, thanks Jorge!

[jmartinesp]

LGTM. We can always iterate on it later, but it does look more like the figma designs.

It's a shame the screenshots are kind of broken, but that's a bug in Paparazzi as you mentioned.