Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homeserver url field apparently requires https:// prefix #1144

Closed
ara4n opened this issue Aug 24, 2023 · 5 comments
Closed

Homeserver url field apparently requires https:// prefix #1144

ara4n opened this issue Aug 24, 2023 · 5 comments
Labels
A-Signin Login screens and signing in O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@ara4n
Copy link
Member

ara4n commented Aug 24, 2023

Steps to reproduce

  1. Change homeserver at login
  2. Enter element.io into the server box
  3. According to @rxl881 it causes weird errors unless you prefix with https://

Outcome

What did you expect?

no https:// prefix needed

Your phone model

No response

Operating system version

No response

Application version and app store

0.1.2 (40001020) playstore

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No

@ara4n ara4n added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Aug 24, 2023
@julioromano julioromano added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Signin Login screens and signing in labels Aug 28, 2023
@bmarty
Copy link
Member

bmarty commented Aug 28, 2023

I do not reproduce the issue. When entering element.io, the homeserver element.io is displayed in the list as a valid result:

image

The application will propose to use the homeserver, even if no .well-known file is detected and valid only if the url is complete though.

For instance with nochance.org:

image image

But when selecting nochance.org, this error will be displayed:

image

@rxl881 do you repro with the latest nightly? We will release a new version in the AppStore very soon, you can try to repro on this one.

(Link to the code which resolve homeservers: https://github.com/vector-im/element-x-android/blob/develop/features/login/impl/src/main/kotlin/io/element/android/features/login/impl/resolver/HomeserverResolver.kt#L74)

@rxl881
Copy link

rxl881 commented Aug 30, 2023

I think that this was a combination of me using the wrong homesaerver domain and also a dark theme bug whereby I couldn't see the results of the search.

Specifically, I was trying to log in to the vector.modular.im homeserver (not element.io). I forgot that it was on a modular subdomain and instead was trying to log in with vector.im, which returned no results (that I could see). I then tried https://vector.im, which did return a result which I then clicked on, but obviously failed to log me in against. I guess that matches with the screenshot that you provided above (as there was no .well-known for the domain that I specified, but it tried anyway when I specified the full URL).

More of a UX issue, but I was a bit confused by the phrase "search term or domain address" ... I get what we're going for here (trying to make it less technical), but it seemed a bit unclear when I was looking to input the "homeserver name" or "homeserver domain", which would be a more precise.

@bmarty
Copy link
Member

bmarty commented Aug 30, 2023

For the wording, this is a product team's decision, we are just integrating it. CC @VolkerJunginger if we want to improve this.

@anoadragon453
Copy link
Member

Should this get an X-Needs-Product label?

@spaetz
Copy link

spaetz commented Jan 17, 2024

Given the server field does not need https:// prefixed, can this be closed? The wording is really a different issue.

@jmartinesp jmartinesp closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Signin Login screens and signing in O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

7 participants