Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Emojibase #1118

Closed
langleyd opened this issue Aug 22, 2023 · 1 comment · Fixed by #1162
Closed

Integrate Emojibase #1118

langleyd opened this issue Aug 22, 2023 · 1 comment · Fixed by #1162
Assignees
@langleyd
Labels
A-Reactions O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@langleyd
Copy link
Member

Context

At the moment web, android and iOS all use different datasources for their emoji picker. This means inconsistencies in what emojis are available(the iOS one is a bit out of date so is missing the new emojis), order they are displayed, different tags etc.

It can also result in bugs like this where the data sent by each client may vary(incorrect unicode points):
image

https://github.com/milesj/emojibase that web uses seems to make most sense, it provides just the json and is spec compliant(generated directly from http://unicode.org/Public/emoji/). It also has translations which we could take advantage of for tags, so that the picker search works for people in non-english languages.

https://github.com/matrix-org/emojibase-bindings is a new repo that provides bindings for the 3 platforms.

We need to replace com.vanniktech:emoji-google with this.
@langleyd langleyd self-assigned this Aug 22, 2023
@langleyd langleyd added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Aug 22, 2023
@langleyd
Copy link
Member Author

Fixed on ios in element-hq/element-x-ios#1449.

@kittykat kittykat added A-Reactions S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Z-Schedule labels Aug 22, 2023
@langleyd langleyd mentioned this issue Aug 28, 2023
Merged
@langleyd langleyd mentioned this issue Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@langleyd langleyd

Labels
A-Reactions O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emojibase integration element-hq/element-x-android
2 participants
@kittykat @langleyd