Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user controls for whether to display media (including thumbnails) #2518

Open
2 tasks done
jimmackenzie opened this issue Sep 3, 2024 · 7 comments
Open
2 tasks done

Comments

@jimmackenzie
Copy link

jimmackenzie commented Sep 3, 2024

Your use case

What would you like to do?

As a user, I should be able to control whether my client displays images and other media automatically. Ideally, I can adjust where this setting applies, based on my level of trust.

Why would you like to do it?

  • As a safety control, to reduce my risk of viewing harmful imagery and other media
  • As a privacy control, to reduce what is displayed while I'm using my device in public
  • As a bandwidth control, to reduce the media I download passively

How would you like to achieve it?

Element Web and Element Desktop (and the older mobile apps) offer tools to disable image previews by default. Nheko recently implemented a variation, where media is hidden by default in public rooms, which I really like as an option (but I would like the option to disable everywhere by default, and have the option to hide in public rooms as a alternative option).

Previews should also be disabled in push notifications from the affected room types.

Where possible, this control should be listed under a safety or privacy heading.

Have you considered any alternatives?

No response

Additional context

No response

Tasks

  1. T-Enhancement
    bmarty
  2. A-Media T-Enhancement
    pixlwave
@bmarty
Copy link
Member

bmarty commented Sep 4, 2024

On Element Web, we have the option "Show previews/thumbnails for images" in the settings, which is enabled by default:

image

When disabled, images are rendered like this in the timeline:

image

And clicking on "Show image" the application first render the blurhash (if available) then the image. Other images on the timeline are not affected by the action, other images still have "Show image" button.

Notes:

  • this affect all media with preview (images, videos, Gifs, ...)
  • this also affect media sent by the current user.

Questions:

  1. Element Web seems to remember which images have been rendered when opening the room again, do we want to have the same mechanism on mobile applications?
  2. Element X may render the blurhash in all cases, would it be acceptable?

@jimmackenzie
Copy link
Author

  1. Element Web seems to remember which images have been rendered when opening the room again, do we want to have the same mechanism on mobile applications?

Providing there is a way to hide the image again, that would be great

  1. Element X may render the blurhash in all cases, would it be acceptable?

It could be - I'm partial to how Element Web does things, because I think the Show image affordance is more useful and looks better than the blurhash in the timeline, but that's a subjective take.

@bmarty
Copy link
Member

bmarty commented Sep 5, 2024

OK thanks. I do not think there is a way to hide the image again on Web, but I may have missed it. We may keep it simple for now and always hide the images when opening the timeline on the mobile clients.

@mxandreas can you give product POV on this please? Ideally we would need some design as well.

@davidegirardi
Copy link

Today I noticed Element Web/Desktop automatically downloads any audio file in the timeline. This is a bandwidth waste and also is probably the cause of issues such as the ones where a lot of audio files or voice messages are in a room (can't find them right now).

I think any media file should follow the setting discussed in this issue.

@davidegirardi
Copy link

@mxandreas
Copy link

EW currently still shows the video's first frame, even when the Show previews/thumbnails for images is OFF. Checking if this isn't a problem or if there's another way on EW to disable this?

@FSG-Cat
Copy link

FSG-Cat commented Sep 19, 2024

EW currently still shows the video's first frame, even when the Show previews/thumbnails for images is OFF. Checking if this isn't a problem or if there's another way on EW to disable this?

Its non desired behavior.

You should be able to control the preview behavior for all types of media.

Edit: But you currently can not control that specific aspect yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants