-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device dehydration v2 #7630
Device dehydration v2 #7630
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7630 +/- ##
========================================
Coverage 12.21% 12.22%
========================================
Files 1648 1648
Lines 163667 163614 -53
Branches 67195 67154 -41
========================================
+ Hits 19996 19999 +3
+ Misses 143026 142970 -56
Partials 645 645
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although missing a changelog.
Riot/Modules/SecureBackup/Setup/SecureBackupSetupCoordinator.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it only working if you verify with 4S?
Fixes #6366 |
- add support for device dehydration v2 i.e. `org.matrix.msc3814` - run dehydration flows after successfully recovering or creating secrets - enable said flows based on .well-known `org.matrix.msc3814` config key - delete previous implementation and helper methods
baf029b
to
9b59428
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
org.matrix.msc3814
org.matrix.msc3814
config keyBased on matrix-org/matrix-ios-sdk#1807