Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use v3 API for crypto endpoints #7557

Open
nisbet-hubbard opened this issue May 24, 2023 · 2 comments · May be fixed by matrix-org/matrix-ios-sdk#1789
Open

Use v3 API for crypto endpoints #7557

nisbet-hubbard opened this issue May 24, 2023 · 2 comments · May be fixed by matrix-org/matrix-ios-sdk#1789
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@nisbet-hubbard
Copy link

nisbet-hubbard commented May 24, 2023 •
edited
Loading

Currently, element uses /_matrix/client/r0/keys/signatures/upload instead of the newer and correct /_matrix/client/v3/keys/signatures/upload route. As a result, attempts to set up key backup on the Conduit implementation of Matrix, for example, throw errors.

This has also been documented and fixed for FluffyChat: https://gitlab.com/famedly/fluffychat/-/issues/986.
@Velin92
Copy link
Member

Velin92 commented May 25, 2023

Thanks for the feedback, actually I'll propagate this issue in the matrix iOS SDK since there is where the update should be done

@Velin92 Velin92 added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Product Requires input from the product team labels May 25, 2023
@Velin92 Velin92 mentioned this issue May 25, 2023
Open
@Velin92 Velin92 removed the X-Needs-Product Requires input from the product team label May 25, 2023
@nisbet-hubbard
Copy link
Author

Thanks! I’ll keep track over there.

@Velin92 Velin92 linked a pull request May 30, 2023 that will close this issue
Open
@Velin92 Velin92 linked a pull request May 30, 2023 that will close this issue
Updating Crypto API to v3 matrix-org/matrix-ios-sdk#1789
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating Crypto API to v3 matrix-org/matrix-ios-sdk
2 participants
@Velin92 @nisbet-hubbard