-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoadBrowserProcessSpecificV8Snapshot fuse yields a crashing package #8797
Comments
Hi there! electron-builder just unpacks an electron release artifact, so my initial guess here is that the |
I meet this problem too, all latest version, changing fuses with @elecron/fuses |
Pretty sure you're supposed to compile/build/provide your OWN browser snapshot in order to use that fuse as it's specific to your own installed (or forked) electron version.
Doing this does nothing different than having Overall, this isn't a bug, it's an end-user misconfiguration. Happy to be proven otherwise, but I'm not finding any resources on how to compile a |
The fuses page says separate snapshots can also improve security
Which could be construed as a form of scope isolation but agreed the docs are lacking |
I think ultimately this issue is about https://www.electron.build/tutorials/adding-electron-fuses.html#loadbrowserprocessspecificv8snapshot not being clear, it looks like something you can just enable |
Let me ask the electron HQ folks and get back to you on this. I see a way electron-builder could auto-copy the default snapshot (for the security hardening between main and renderer) while also allowing a user-supplied one to be copied instead. I need to see first if they're okay with that. |
Hi! I did some experiments to speed up Electron app startup time using V8 snapshots in https://github.com/RaisinTen/electron-snapshot-experiment, so y'all might find that useful. If you browse the repo at https://github.com/RaisinTen/electron-snapshot-experiment/tree/a3bf2c070d2aa72bf17720c1e7fdc95970c1a3ca, you can find out more about how to use the LoadBrowserProcessSpecificV8Snapshot fuse. |
Here's a snippet of the response from Electron dev chat
What this means is that I'll need to change the property
electron-builder will handle the copying and throw an error if the file can't be found. If the snapshot files are successfully copied, then the fuse is activated. I'll probably also log a warning that |
[0122/170408.987:FATAL:v8_initializer.cc(687)] Error loading V8 startup snapshot file
Digging deeper,
LoadBrowserProcessSpecificV8Snapshot
wants abrowser_v8_context_snapshot.bin
but this does not exist in the buildCopying
v8_context_snapshot.bin
tobrowser_v8_context_snapshot.bin
seems to resolve the issueThe text was updated successfully, but these errors were encountered: