Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove url-search-params-polyfill (included in babel now) #4079

Merged
merged 1 commit into from
May 3, 2022
Merged

Remove url-search-params-polyfill (included in babel now) #4079

merged 1 commit into from
May 3, 2022

Conversation

VIKTORVAV99
Copy link
Member

With the merger of #4078 this feature is already polyfilled by babel and corejs3 and we no longer need the separate polyfill.

@VIKTORVAV99
remove url-search-params-polyfill
abc1bc1 
this feature is polyfilled by babel and corejs3 now
@github-actions github-actions bot added dependencies Pull requests that update a dependency file frontend 🎨 labels May 3, 2022
madsnedergaard
madsnedergaard approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@madsnedergaard madsnedergaard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye IE11 🥳
I just looked at our analytics, and it's quite interesting how usage of IE11 totally disappeared at some point:

Screenshot 2022-05-03 at 13 56 17

@madsnedergaard madsnedergaard merged commit 77668ca into electricitymaps:master May 3, 2022
@VIKTORVAV99
Copy link
Member Author

Bye IE11 🥳
I just looked at our analytics, and it's quite interesting how usage of IE11 totally dropped a few years back:

Screenshot 2022-05-03 at 13 56 17

Does that mean we can drop support for IE11? 👀

That would make it considerably easier to use new features.

@VIKTORVAV99 VIKTORVAV99 deleted the remove_url-search-params-polyfill branch May 3, 2022 12:01
@VIKTORVAV99 VIKTORVAV99 mentioned this pull request May 3, 2022
Merged
@FelixDQ FelixDQ mentioned this pull request Jun 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsnedergaard madsnedergaard madsnedergaard approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file frontend 🎨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VIKTORVAV99 @madsnedergaard