Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impt dg create doesn't support --load-code-after-blessing? #28

Open
rlipscombe opened this issue Aug 28, 2018 · 5 comments
Open

impt dg create doesn't support --load-code-after-blessing? #28

rlipscombe opened this issue Aug 28, 2018 · 5 comments
Assignees

Comments

@rlipscombe
Copy link

At least the help text suggests it's not supported.

@alexey-nbl
Copy link
Contributor

Yes. Because the impCentral API does not support it in the create DG request.
http://apidoc.electricimp.com/#tag/Devicegroups
Newly created DG always has it 'true' (if nothing has been changed during last months).

But it's possible to change it using 'impt dg update'.

@ppetrosh
Copy link
Contributor

It doesn't prevent the tool from making this request for the user after the DG is created...

@alexey-nbl
Copy link
Contributor

Yes, can be supported by impt using two requests. But I would not do it as:

  • there seems no real benefit. Assuming a script can easily do the same using two impt commands.
  • and a downside is one more complexity in already huge impt.

But if it is really required, may be added into impt.

@ppetrosh ppetrosh self-assigned this Aug 28, 2018
@ppetrosh
Copy link
Contributor

I don't have a strong opinion here and would let @rlipscombe comment.

@rlipscombe
Copy link
Author

I could live with some extra help text in impt dg create that said something along the lines of "use impt dg update for other options".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants