Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide-on & show-on seem to break anything that isn't set as display block #11

Open
Shrinks99 opened this issue Jan 13, 2020 · 1 comment

Comments

@Shrinks99
Copy link

When using hide-on and show-on to change the visibility of an element set to display: flex; it seems to override the existing display mode and set it to block which is undesired. Setting show-on to display: inherit seems to have fixed this for me but I don't feel confident enough in my CSS skills to just go and submit a PR for this issue!

Would appreciate it if somebody a little more knowledgeable wouldn't mind testing this ;P

@electerious
Copy link
Owner

.show-on- changes the rows to flex and the columns to block (https://github.com/electerious/basicGrid/blob/master/src/styles/_mixins.scss). This might be problematic if you're overwriting some styling of the grid.

Changing it to display: inherit might work for columns, but I've uses basicGrid in so may projects I seriously can't tell if this works in all cases.

I will give it a try by time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants