-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse UA on the server-side #28
Comments
The main reason was that Ackee shouldn't process the user agent / shouldn't even receive the user agent when The seconds reason was that It could work if we find a good API declaration for it, but it's also not as clean & simple as it is right now. |
I would like to keep the current API unchanged. It's good for apps where a UA isn't a thing. The UA could be an optional GraphQL query parameter that get's parsed when available. Data + UA = Parses UA. Fields specified in the data will overwrite fields parsed from the UA. In the case it's like a fallback, but it would allow us to remove the platform library from |
Yeah, most internet capable device sends a User-Agent string to the server on each request. I also understand that Ackee shouldn't process the data, unless the user has given their permission. |
The feature didn't made it into v3, but it's something I'm planning for a future release. |
What if the platform.js library is loaded on demand externally instead? If a developer turns on |
@thecodrr that would increase load time, as another js file has to be downloaded and parsed |
My plan is to add an optional userAgent parameter to the createRecord mutation.
|
Why is the parsing of the UA done on the client side, and not the server side?
You could potentially save 15kB (~8kB gzip). It's not much, but it can be done server side.
The text was updated successfully, but these errors were encountered: