feat: Drop support for Python 3.8 [ES-8947] #1893
Open
+33
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@favilo I've removed 3.8 from required checks in GH branch protections to unblock this PR. |
This will allow us to make some long desired tech debt changes in the future.
- Install black as dev dependency - format esrally/utils/net.py, since black's new configuration didn't like the old one. - Fix doc warning in docs/migrate.rst
pquentin
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Thanks!
- Should we suggest using a more recent version of Python in the
docker runcommand indocs/docker.rst? - Should we remove the
remove_prefixfunction in esrally/driver/runner.py? - Should we switch to
--py39-plusin.pre-commit-config.yml? - Is there a specific setup to do on the night-rally environments?
| Minimum Python version is 3.9.0 | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| Rally 2.12.0 requires Python 3.9.0. Check the :ref:`updated installation instructions <install_python>` for more details. |
There was a problem hiding this comment.
Suggested change
| Rally 2.12.0 requires Python 3.9.0. Check the :ref:`updated installation instructions <install_python>` for more details. | |
| Rally 2.12.0 requires Python 3.9.0 or above. Check the :ref:`updated installation instructions <install_python>` for more details. |
| @@ -73,8 +73,8 @@ | |||
|
|
|||
|
|
|||
| def check_python_version(): | |||
| if sys.version_info.major != 3 or sys.version_info.minor < 8: | |||
| raise RuntimeError("Rally requires at least Python 3.8 but you are using:\n\nPython %s" % str(sys.version)) | |||
| if sys.version_info.major != 3 or sys.version_info.minor < 9: | |||
There was a problem hiding this comment.
Not related to the pull request, but this can be simplified as sys.version_info is a named tuple:
Suggested change
| if sys.version_info.major != 3 or sys.version_info.minor < 9: | |
| if sys.version_info < (3, 9): |
| @@ -138,7 +139,7 @@ esrallyd = "esrally.rallyd:main" | |||
|
|
|||
| [tool.black] | |||
| line-length = 140 | |||
| target-version = ['py38'] | |||
| target-version = ['py39', 'py310', 'py311'] | |||
There was a problem hiding this comment.
TIL that all supported versions should be included. Which means Python 3.12 should be there too?
Suggested change
| target-version = ['py39', 'py310', 'py311'] | |
| target-version = ['py39', 'py310', 'py311', 'py312'] |
There was a problem hiding this comment.
That wasn't recognized as a valid target when I originally tried it, however, I would guess we could get it to work by upgrading the version of black we have installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to make some long desired tech debt changes in the future.
make check-allsuccessfully?