Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raw-request task in nyc_taxis#esql fails with request [/_esql] contains unrecognized parameter: [request_timeout]" #393

Closed
dliappis opened this issue Apr 15, 2023 · 2 comments
Closed

raw-request task in nyc_taxis#esql fails with request [/_esql] contains unrecognized parameter: [request_timeout]" #393

dliappis opened this issue Apr 15, 2023 · 2 comments
Assignees
@b-deam
Labels
bug

Comments

@dliappis
Copy link
Contributor

I think this is related to the elasticsearch-py upgrade to 8.x in Rally (I haven't tested with an older version yet), but when running the nyc_taxis/esql track we are getting:

Running multi_terms-keyword_esql_shard_partitioning                            [  0% done][ERROR] Cannot race. Error in load generator [0]
        Cannot run task [multi_terms-keyword_esql_shard_partitioning]: Request returned an error. Error type: api, Description: <_io.BytesIO object at 0x7f836ba36e80> ({"error":{"root_cause":[{"type":"illegal_argument_exception","reason":
"request [/_esql] contains unrecognized parameter: [request_timeout]"}],"type":"illegal_argument_exception","reason":"request [/_esql] contains unrecognized parameter: [request_timeout]"},"status":400})

Without digging deeper, I think this is because the particular task is a raw-request and we are specifying request-timeout:

rally-tracks/nyc_taxis/operations/default.json

Line 1175 in 20b8183

"request-timeout": 120,
) which, according to elastic/rally#1673, it should be, instead, in client.options()?

If yes, I see at least two ways to work around this:

  1. Switch from raw-request to a custom runner and manipulate the timeout there
  2. Add logic in the raw-request runner of Rally to do that itself
@dliappis dliappis added the bug label Apr 15, 2023
@dliappis
Copy link
Contributor Author

cc @csoulios

@b-deam b-deam mentioned this issue Apr 18, 2023
Merged
dliappis pushed a commit to elastic/rally that referenced this issue Apr 19, 2023
@b-deam
Refactor runners that use '_transport_request_params()' to set transp…
79e05b2 
…ort level options via 'options()' (#1705)

With this commit we fix a bug that prevented any runner using the low
level `perform_request()` ES client method, and `_transport_request_params()`
helper method from passing in the `request-timeout` parameter.

Relates #1673 
Relates elastic/rally-tracks#393

Note that there's still follow up work to be done to refactor the remaining runners, specifically around overriding the client's `options()` method to handle the `distribution_version` param to support REST compatibility headers as discussed in #1673, but that will only affect us when 9.x is released.
@b-deam
Copy link
Member

b-deam commented Oct 24, 2023

elastic/rally#1705 closed this.

@b-deam b-deam closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b-deam b-deam

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dliappis @b-deam