mergify: support backports automation with labels #16937
Draft
+235
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
commented
Jan 24, 2025
Comment on lines
+7
to
+9
| - main | ||
| - 8.* | ||
| - 9.* |
There was a problem hiding this comment.
I decided to skip 7.17 for the pre-commit validation.
v1v
commented
Jan 24, 2025
Comment on lines
+28
to
+30
| env: | ||
| INPUTS_BRANCH: "${{ inputs.branch }}" | ||
| INPUTS_BUMP: "${{ inputs.bump }}" |
There was a problem hiding this comment.
Best practice to avoid shell injection
| steps: | ||
| - name: Fetch logstash-core team member list | ||
| uses: tspascoal/get-user-teams-membership@v1 | ||
| uses: tspascoal/get-user-teams-membership@57e9f42acd78f4d0f496b3be4368fc5f62696662 #v3.0.0 |
There was a problem hiding this comment.
Best practice, tags are mutable.
| @@ -37,14 +40,14 @@ jobs: | |||
| if: ${{ steps.checkUserMember.outputs.isTeamMember == 'false' }} | |||
| run: exit 1 | |||
| - name: checkout repo content | |||
| uses: actions/checkout@v2 | |||
| uses: actions/checkout@v4 | |||
There was a problem hiding this comment.
Best practice, update checkout, we trust actions/checkout
Comment on lines
+64
to
+66
| - name: Create GitHub backport label (Mergify) (minor only) | ||
| if: ${{ inputs.bump == 'minor' }} | ||
| continue-on-error: true |
There was a problem hiding this comment.
Only for minor releases we create the backport labels. for major releases is not needed
|
💚 Build Succeeded
History
cc @v1v |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
conflicts8.xby default unlessbackport-skip)Mergifydoes not support this feature out of the box, see github-actions: support for copying the backport labels apm-server#15190minor.minor.Why is it important/What is the impact to the user?
Use the same backport mechanism as done in some other projects. While still support for the former approach.
Tasks
Follow-ups
Checklist
Author's Checklist
How to test this PR locally
Related issues
Relates #16933
Use cases
Screenshots
Logs