Use --qualifier in release manager #16907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dliappis
force-pushed
the
support-version-qualifier-in-dra-pipelines
branch
5 times, most recently
from
2490ac0 to
c04c861
Compare
This commit uses the new --qualifier parameter in the release manager for publishing dra artifacts. Additionally, simplifies the expected variables to rely on a simple `VERSION_QUALIFIER`. Finally, we skip snapshot builds when VERSION_QUALIFIER is set. Closes elastic/ingest-dev#4856
dliappis
force-pushed
the
support-version-qualifier-in-dra-pipelines
branch
4 times, most recently
from
bfe86fc to
1b09742
Compare
dliappis
force-pushed
the
support-version-qualifier-in-dra-pipelines
branch
from
1b09742 to
56fdaac
Compare
dliappis
force-pushed
the
support-version-qualifier-in-dra-pipelines
branch
from
fdb0d73 to
95bdd77
Compare
This reverts commit 56fdaac.
dliappis
commented
Jan 17, 2025
|
|
||
| echo "--- Building [${WORKFLOW_TYPE}] artifacts" | ||
| echo "--- Building [$${WORKFLOW_TYPE}] artifacts" |
There was a problem hiding this comment.
this is not a typo, it was a bug :) double $ are required otherwise the variable gets interpolated by BK.
rowlandgeoff
approved these changes
Jan 17, 2025
dliappis
force-pushed
the
support-version-qualifier-in-dra-pipelines
branch
from
fd7d23c to
e5fbdfc
Compare
|
💚 Build Succeeded
History
cc @dliappis |
2 tasks
andsel
approved these changes
Jan 20, 2025
|
@logstashmachine backport 8.x |
|
@logstashmachine backport 8.17 |
|
@logstashmachine backport 8.16 |
|
@logstashmachine backport 7.17 |
dliappis
added a commit
to dliappis/logstash
that referenced
this pull request
Jan 20, 2025
This commit uses the new --qualifier parameter in the release manager for publishing dra artifacts. Additionally, simplifies the expected variables to rely on a simple `VERSION_QUALIFIER`. Snapshot builds are skipped when VERSION_QUALIFIER is set. Finally, for helping to test DRA PRs, we also allow passing the `DRA_BRANCH` option/env var to override BUILDKITE_BRANCH. Closes elastic/ingest-dev#4856
dliappis
added a commit
to dliappis/logstash
that referenced
this pull request
Jan 20, 2025
This commit uses the new --qualifier parameter in the release manager for publishing dra artifacts. Additionally, simplifies the expected variables to rely on a simple `VERSION_QUALIFIER`. Snapshot builds are skipped when VERSION_QUALIFIER is set. Finally, for helping to test DRA PRs, we also allow passing the `DRA_BRANCH` option/env var to override BUILDKITE_BRANCH. Closes elastic/ingest-dev#4856
dliappis
added a commit
that referenced
this pull request
Jan 20, 2025
…16913) This commit uses the new --qualifier parameter in the release manager for publishing dra artifacts. Additionally, simplifies the expected variables to rely on a simple `VERSION_QUALIFIER`. Snapshot builds are skipped when VERSION_QUALIFIER is set. Finally, for helping to test DRA PRs, we also allow passing the `DRA_BRANCH` option/env var to override BUILDKITE_BRANCH. Closes elastic/ingest-dev#4856 Backported from #16907 cherry picked from 9385cfa
dliappis
added a commit
to dliappis/logstash
that referenced
this pull request
Jan 24, 2025
This commit uses the new --qualifier parameter in the release manager for publishing dra artifacts. Additionally, simplifies the expected variables to rely on a simple `VERSION_QUALIFIER`. Snapshot builds are skipped when VERSION_QUALIFIER is set. Finally, for helping to test DRA PRs, we also allow passing the `DRA_BRANCH` option/env var to override BUILDKITE_BRANCH. Closes elastic/ingest-dev#4856
dliappis
added a commit
to dliappis/logstash
that referenced
this pull request
Jan 24, 2025
This commit uses the new --qualifier parameter in the release manager for publishing dra artifacts. Additionally, simplifies the expected variables to rely on a simple `VERSION_QUALIFIER`. Snapshot builds are skipped when VERSION_QUALIFIER is set. Finally, for helping to test DRA PRs, we also allow passing the `DRA_BRANCH` option/env var to override BUILDKITE_BRANCH. Closes elastic/ingest-dev#4856
dliappis
added a commit
to dliappis/logstash
that referenced
this pull request
Jan 24, 2025
This commit uses the new --qualifier parameter in the release manager for publishing dra artifacts. Additionally, simplifies the expected variables to rely on a simple `VERSION_QUALIFIER`. Snapshot builds are skipped when VERSION_QUALIFIER is set. Finally, for helping to test DRA PRs, we also allow passing the `DRA_BRANCH` option/env var to override BUILDKITE_BRANCH. Closes elastic/ingest-dev#4856
dliappis
added a commit
that referenced
this pull request
Jan 24, 2025
…16941 Backport of #16907 cherry-picked from 9385cfa This commit uses the new --qualifier parameter in the release manager for publishing dra artifacts. Additionally, simplifies the expected variables to rely on a simple `VERSION_QUALIFIER`. Snapshot builds are skipped when VERSION_QUALIFIER is set. Finally, for helping to test DRA PRs, we also allow passing the `DRA_BRANCH` option/env var to override BUILDKITE_BRANCH. Closes elastic/ingest-dev#4856
dliappis
added a commit
that referenced
this pull request
Jan 24, 2025
…16942 Backport of #16907 cherry picked from 9385cfa This commit uses the new --qualifier parameter in the release manager for publishing dra artifacts. Additionally, simplifies the expected variables to rely on a simple `VERSION_QUALIFIER`. Snapshot builds are skipped when VERSION_QUALIFIER is set. Finally, for helping to test DRA PRs, we also allow passing the `DRA_BRANCH` option/env var to override BUILDKITE_BRANCH. Closes elastic/ingest-dev#4856
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
This commit uses the new --qualifier parameter in the release manager for publishing dra artifacts. Additionally, simplifies the expected variables to rely on a simple
VERSION_QUALIFIER.Finally, we skip snapshot builds when VERSION_QUALIFIER is set.
Why is it important/What is the impact to the user?
Enables prerelease staging builds
How to test this PR
To test via this PR supply the following BK options to the staging pipeline:
which results in a successful build -> https://buildkite.com/elastic/logstash-dra-staging-pipeline/builds/177
Once it's merged, manual staging builds need to be triggered using only
VERSION_QUALIFIER; docs will be updated for https://docs.elastic.dev/ingest-dev-docs/logstash/dra#usage-of-version_qualifier_opt via a follow up PR.Also tested a snapshot build to ensure nothing's broken (this just requires
DRA_BRANCH="main"as params), it's successful -> https://buildkite.com/elastic/logstash-dra-snapshot-pipeline/builds/2052Related issues
Closes https://github.com/elastic/ingest-dev/issues/4856
Screenshots