Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pipeline bus v1 #16895

Merged
merged 1 commit into from
Jan 10, 2025
Merged

remove pipeline bus v1 #16895

merged 1 commit into from
Jan 10, 2025

Conversation

yaauie
Copy link
Member

@yaauie yaauie commented Jan 10, 2025

Release notes

  • removes deprecated v1 pipeline bus; the v2 implementation has been proven safe since 8.17.0, 8.16.1, and 8.15.5.

What does this PR do?

Removes the v1 implementation of the pipeline bus, which was only accessible through a system property escape hatch. The hatch was useful in releases of Logstash where the default v2 implementation was at risk of a deadlock during shutdown (8.15.0 - 8.15.4, 8.16.0), but is no longer useful.

The property is deprecated on the 8.x branch in #16643

Why is it important/What is the impact to the user?

If the system property is specified on an upgraded Logstash, it will be silently ignored.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

@yaauie yaauie mentioned this pull request Jan 10, 2025
2 tasks
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on 🟢 CI.

Copy link

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@yaauie yaauie merged commit 348f162 into elastic:main Jan 10, 2025
6 checks passed
@yaauie yaauie deleted the remove-pipeline-bus-v1 branch January 10, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants