Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update running-logstash-kubernetes.asciidoc #16893

Open
wants to merge 2 commits into
base: 8.17
Choose a base branch
from
Open

Conversation

flexitrev
Copy link

Removed technical preview language

Type of change

  • doc
    -->

Release notes

[rn:skip]

What does this PR do?

Why is it important/What is the impact to the user?

change of release state

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Removed technical preview language
@flexitrev flexitrev requested a review from karenzone January 10, 2025 14:39
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, thank you! ❤️
Please use active voice and add punctuation (as suggested inline).

Shouldn't this be based out of main rather than 8.17?

docs/static/running-logstash-kubernetes.asciidoc Outdated Show resolved Hide resolved
@flexitrev
Copy link
Author

I was going to go out of main, but it gave me an angry warning, so I was trying to be safe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants