-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_score
should not be a reserved attribute in ES|QL
#118435
base: main
Are you sure you want to change the base?
Conversation
Documentation preview: |
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Hi @tteofili, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look right with me!
Can we get a CSV test just to prevent any future regressions with allowing _score
to be overwritten?
Something like what you had in the test before: "from foo metadata _score | where qstr(\"bar\") | eval _score = _score + 1"
and another one where _score
receives a different type:
from foo metadata _score | where qstr(\"bar\") | eval _score = "foobar"
with that, I think this should be good to go!
also what would happen if |
I did not realize this would actually create a problem for bwc 8.18 tests - feel free to remove them and then we can add them later after the changes make it in 8.18.
|
Hi @tteofili, I've updated the changelog YAML for you. |
Drop checks in ES|QL
Verifier
that ensured_score
is a reserved attribute.These checks are too restrictive, in addition to that relaxing them would make handling of
_score
consistent with other (metadata) attributes and fields.fixes #118460