Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESQL: Add CCS tests for FLS and DLS against data streams #118423

Merged
merged 9 commits into from
Dec 12, 2024
Merged

ESQL: Add CCS tests for FLS and DLS against data streams #118423

merged 9 commits into from
Dec 12, 2024

Conversation

n1v0lg
Copy link
Contributor

@n1v0lg n1v0lg commented Dec 11, 2024

CCS test coverage for #118378

@n1v0lg n1v0lg added >test Issues or PRs that are addressing/adding tests :Analytics/EQL EQL querying v9.0.0 v8.17.0 v8.16.2 v8.18.0 labels Dec 11, 2024
@n1v0lg n1v0lg self-assigned this Dec 11, 2024
@n1v0lg n1v0lg changed the title ESQL: Add CCS tests for DLS against data stream ESQL: Add CCS tests for FLS and DLS against data streams Dec 11, 2024
@n1v0lg n1v0lg requested a review from nik9000 December 11, 2024 14:12
nik9000
nik9000 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good way to go to me. I would have put it in an x-pack/plugin/esql/qa submodule, but it's just fine here.

@n1v0lg n1v0lg marked this pull request as ready for review December 11, 2024 17:01
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Dec 11, 2024
@n1v0lg n1v0lg added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Dec 11, 2024
@n1v0lg
Copy link
Contributor Author

n1v0lg commented Dec 11, 2024

@nik9000 thanks for the review! I'll merge as is to get more runs in CI, then follow up with more coverage/clean up.

@n1v0lg
Copy link
Contributor Author

n1v0lg commented Dec 11, 2024

I would have put it in an x-pack/plugin/esql/qa submodule, but it's just fine here.

The reason I put it under xpack.remotecluster is because there's a lot of test machinery around RCS that I'm re-using. The other ES|QL CCS suite is also here.

@n1v0lg n1v0lg added the auto-backport Automatically create backport pull requests when merged label Dec 11, 2024
@n1v0lg n1v0lg merged commit 80a1a6f into main Dec 12, 2024
17 of 18 checks passed
@n1v0lg n1v0lg deleted the esql-dls-opt-in-ccs-test branch December 12, 2024 07:59
@n1v0lg n1v0lg restored the esql-dls-opt-in-ccs-test branch December 12, 2024 08:00
@n1v0lg n1v0lg deleted the esql-dls-opt-in-ccs-test branch December 12, 2024 08:00
@n1v0lg n1v0lg mentioned this pull request Dec 12, 2024
Merged
n1v0lg added a commit to n1v0lg/elasticsearch that referenced this pull request Dec 12, 2024
@n1v0lg
ESQL: Add CCS tests for FLS and DLS against data streams (elastic#118423
9ddd9ae 
)

CCS test coverage for elastic#118378
n1v0lg added a commit to n1v0lg/elasticsearch that referenced this pull request Dec 12, 2024
@n1v0lg
ESQL: Add CCS tests for FLS and DLS against data streams (elastic#118423
b83af4e 
)

CCS test coverage for elastic#118378
This was referenced Dec 12, 2024
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.17
✅ 8.16
✅ 8.x

n1v0lg added a commit to n1v0lg/elasticsearch that referenced this pull request Dec 12, 2024
@n1v0lg
ESQL: Add CCS tests for FLS and DLS against data streams (elastic#118423
2530fcc 
)

CCS test coverage for elastic#118378
elasticsearchmachine pushed a commit that referenced this pull request Dec 12, 2024
@n1v0lg
ESQL: Add CCS tests for FLS and DLS against data streams (#118423) (#…
0c9090b 
…118525)

CCS test coverage for #118378
elasticsearchmachine pushed a commit that referenced this pull request Dec 12, 2024
@n1v0lg
ESQL: Add CCS tests for FLS and DLS against data streams (#118423) (#…
5e36b4b 
…118524)

CCS test coverage for #118378
elasticsearchmachine pushed a commit that referenced this pull request Dec 12, 2024
@n1v0lg
ESQL: Add CCS tests for FLS and DLS against data streams (#118423) (#…
570d78c 
…118526)

CCS test coverage for #118378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees

@n1v0lg n1v0lg

Labels
:Analytics/EQL EQL querying auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.16.2 v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n1v0lg @elasticsearchmachine @nik9000