Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS][ML] Use elasticsearch service instead of deprecated elser service in tutorials #118007

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

davidkyle
Copy link
Member

@davidkyle davidkyle commented Dec 4, 2024

The elser service was deprecated in 8.16

Closes #117829

@davidkyle davidkyle added >docs General docs changes :ml Machine learning auto-backport Automatically create backport pull requests when merged v8.16.0 v9.0.0 v8.17.0 v8.18.0 labels Dec 4, 2024
@davidkyle davidkyle requested a review from kosabogi December 4, 2024 15:45
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:ML Meta label for the ML team labels Dec 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@kosabogi kosabogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't suggest it directly in the file, but at the beginning of the Tutorial: hybrid search with semantic_text:

"This tutorial uses the elser service for demonstration, but you can use any service and its supported models offered by the Inference API."

I think we should change the elser service to elasticsearch, like this:

This tutorial uses the <<infer-service-elasticsearch,elasticsearch service>> for demonstration, but you can use any service and their supported models offered by the {infer-cap} API.

Otherwise, LGTM!

@davidkyle
Copy link
Member Author

Good catch @kosabogi I have pushed those changes

# Conflicts:
#	docs/reference/search/search-your-data/semantic-search-semantic-text.asciidoc
#	docs/reference/search/search-your-data/semantic-text-hybrid-search
@davidkyle
Copy link
Member Author

@kosabogi #117985 addressed most of the same issues in this PR but there is one small change to make. Please can you take a look

@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.16
8.17
8.x

davidkyle added a commit to davidkyle/elasticsearch that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >docs General docs changes :ml Machine learning Team:Docs Meta label for docs team Team:ML Meta label for the ML team v8.16.0 v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial: Semantic Search Documentation using deprecated elser service instead of elasticsearch service
3 participants