Skip to content

Commit

Permalink
[8.x] Backport ignoreOrder marks on LOOKUP JOIN tests (#118136) (#118421
Browse files Browse the repository at this point in the history
)

* ES|QL: make ignoreOrder parsing more strict in CSV tests (#118136)

(cherry picked from commit e9d925e)

# Conflicts:
#	muted-tests.yml
#	x-pack/plugin/esql/qa/testFixtures/src/main/resources/lookup-join.csv-spec

* Unmute

---------

Co-authored-by: Luigi Dell'Aquila <[email protected]>
  • Loading branch information
alex-spies and luigidellaquila authored Dec 11, 2024
1 parent d40813d commit c128a48
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 0 additions & 3 deletions muted-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,3 @@ tests:
- class: org.elasticsearch.reservedstate.service.RepositoriesFileSettingsIT
method: testSettingsApplied
issue: https://github.com/elastic/elasticsearch/issues/116694
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
method: test {lookup-join.LookupMessageFromIndexKeep ASYNC}
issue: https://github.com/elastic/elasticsearch/issues/118399
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ FROM sample_data
| EVAL client_ip = client_ip::keyword
| LOOKUP JOIN clientips_lookup ON client_ip
;
ignoreOrder:true

@timestamp:date | event_duration:long | message:keyword | client_ip:keyword | env:keyword
2023-10-23T13:55:01.543Z | 1756467 | Connected to 10.1.0.1 | 172.21.3.15 | Production
Expand All @@ -159,6 +160,7 @@ FROM sample_data
| LOOKUP JOIN clientips_lookup ON client_ip
| KEEP @timestamp, client_ip, event_duration, message, env
;
ignoreOrder:true

@timestamp:date | client_ip:keyword | event_duration:long | message:keyword | env:keyword
2023-10-23T13:55:01.543Z | 172.21.3.15 | 1756467 | Connected to 10.1.0.1 | Production
Expand Down Expand Up @@ -243,6 +245,7 @@ required_capability: join_lookup_v4
FROM sample_data
| LOOKUP JOIN message_types_lookup ON message
;
ignoreOrder:true

@timestamp:date | client_ip:ip | event_duration:long | message:keyword | type:keyword
2023-10-23T13:55:01.543Z | 172.21.3.15 | 1756467 | Connected to 10.1.0.1 | Success
Expand All @@ -261,6 +264,7 @@ FROM sample_data
| LOOKUP JOIN message_types_lookup ON message
| KEEP @timestamp, client_ip, event_duration, message, type
;
ignoreOrder:true

@timestamp:date | client_ip:ip | event_duration:long | message:keyword | type:keyword
2023-10-23T13:55:01.543Z | 172.21.3.15 | 1756467 | Connected to 10.1.0.1 | Success
Expand Down

0 comments on commit c128a48

Please sign in to comment.