We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
I saw the issue (#1227) where an interface for the Client is added to support mocking in the unittest.
Maybe it is an idea to also let the ClientBuilder have the ClientInterface as returntype instead of Client.
ClientInterface
Client
elasticsearch-php/src/ClientBuilder.php
Line 158 in 9a734ac
Then it will be possible to Mock the ClientBuilder and let fromConfig return a mocked instance.
ClientBuilder
fromConfig
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi,
I saw the issue (#1227) where an interface for the Client is added to support mocking in the unittest.
Maybe it is an idea to also let the ClientBuilder have the
ClientInterface
as returntype instead ofClient
.elasticsearch-php/src/ClientBuilder.php
Line 158 in 9a734ac
Then it will be possible to Mock the
ClientBuilder
and letfromConfig
return a mocked instance.The text was updated successfully, but these errors were encountered: