elastic-opentelemetry-instrumentation-openai: match proposed upstream semconv #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… semconv Update attributes to match open-telemetry/semantic-conventions#1603
trentm
approved these changes
Nov 27, 2024
| @@ -117,7 +117,7 @@ def test_all_the_client_options(provider_str, model, input_tokens, duration, tra | |||
| GEN_AI_REQUEST_MODEL: model, | |||
| GEN_AI_SYSTEM: "openai", | |||
| GEN_AI_RESPONSE_MODEL: model, | |||
| GEN_AI_REQUEST_ENCODING_FORMAT: "float", | |||
| GEN_AI_REQUEST_ENCODING_FORMATS: ("float",), | |||
There was a problem hiding this comment.
Possibly showing my ignorance here. The code sets value of this attribute to a list, but compares it to a tuple here. Why does the == comparison return True?
>>> {"foo":1, "bar":["float"]} == {"foo":1, "bar":("float",)}
FalseThere was a problem hiding this comment.
Lists ends up as tuples for some reason in tests, haven't digged much on where this happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Update attributes to match
open-telemetry/semantic-conventions#1603
Related issues