Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed directive #11

Open
9 tasks
Tracked by #2
Mpdreamz opened this issue Nov 6, 2024 · 2 comments
Open
9 tasks
Tracked by #2

embed directive #11

Mpdreamz opened this issue Nov 6, 2024 · 2 comments
Labels
authoring Relates to our markdown parser

Comments

@Mpdreamz
Copy link
Member

Mpdreamz commented Nov 6, 2024

Embed

Kind Link
Reference https://mystmd.org/guide/directives#directive-embed
Documentation https://mystmd.org/guide/embed

The embed directive allows you to duplicate content from another part of your project. This can also be done through the figure directive.

Implementation

  • Parses directives and aliases
  • Emits HTML
  • Unit tests
  • Validation (emits, warnings and errors).

Specification compliance:

  • Arguments is not parsed and reference a known label
  • Body is not parsed and treated as raw string
  • Options:
    • remove-input (boolean) - If embedding a Jupyter Notebook cell, remove the input of the cell.
    • remove-output (boolean) - If embedding a Jupyter Notebook cell, remove the output of the cell.
@Mpdreamz
Copy link
Member Author

Mpdreamz commented Nov 6, 2024

As per https://mystmd.org/guide/embed and in particular the section on {include} vs {embed}` I am personally leaning on not implementing this directive and emit a warning for its usage.

  • I think it's more prescriptive for reusable content to always live separately and not yank pieces of content from other pages.

What do you think @bmorelli25 ?

(As an aside should we create a GitHub team for folks interested in these types of discussions?)

This was referenced Nov 6, 2024
@Mpdreamz Mpdreamz added enhancement authoring Relates to our markdown parser labels Nov 6, 2024
@bmorelli25
Copy link
Member

cc @KOTungseth. We should discuss this one on Monday. We should also ensure the right writers are involved in these conversations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authoring Relates to our markdown parser
Projects
None yet
Development

No branches or pull requests

2 participants