fix decimator #534
Merged
fix decimator #534
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw for 1, I verified this by inverting the arrays, but I did not commit it here. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #534 +/- ##
=======================================
Coverage 91.50% 91.50%
=======================================
Files 35 35
Lines 4520 4521 +1
=======================================
+ Hits 4136 4137 +1
Misses 384 384
☔ View full report in Codecov by Sentry. |
Merged
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#529 (comment)
'halfedge_.size() % 6 == 0' is false: Not an even number of faces after sorting faces!.Closes #529