Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version discovery regression #356

Open
Alexander-Shukaev opened this issue Jun 4, 2024 · 3 comments
Open

Version discovery regression #356

Alexander-Shukaev opened this issue Jun 4, 2024 · 3 comments
Labels

Comments

@Alexander-Shukaev
Copy link

#352 broke version discovery (made it less robust basically):

which: no nodejs in (/tests/.venv/bin:/opt/bb/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bb/lib64/bin)
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/tests/.venv/lib/python3.11/site-packages/nodeenv.py", line 1544, in <module>
    main()
  File "/tests/.venv/lib/python3.11/site-packages/nodeenv.py", line 1126, in main
    create_environment(env_dir, args)
  File "/tests/.venv/lib/python3.11/site-packages/nodeenv.py", line 1011, in create_environment
    if node_version_from_args(args) < (0, 6, 3) or args.with_npm:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tests/.venv/lib/python3.11/site-packages/nodeenv.py", line 188, in node_version_from_args
    return parse_version(clear_output(out))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tests/.venv/lib/python3.11/site-packages/nodeenv.py", line 178, in parse_version
    return tuple(map(int, version_str.replace('v', '').split('.')))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: invalid literal for int() with base 10: '2+2-b20240418T00453999'
@ekalinin
Copy link
Owner

ekalinin commented Jun 4, 2024

Hey,

Thanks for the report!
Could you please provide a command where you got an error?

@Alexander-Shukaev
Copy link
Author

'/.venv/bin/python3.11', '-mnodeenv', '--prebuilt', '--clean-src', '/.pre-commit/repo2vdt1csj/node_env-system', '-n', 'system'

@ekalinin
Copy link
Owner

ekalinin commented Jun 4, 2024

Hey,

Please, try new version - 1.9.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants