Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix security alerts #70

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

rafaelmakaha
Copy link

Desription

This pull request resolves #69 by fixing dependabot security alerts

I've fixed few alerts by updating package-lock dependencies with a simple npm i, but some dependencies updates might break application as said in npm audit fix. That's why it is in WIP status

@ghost
Copy link

ghost commented Feb 2, 2021

DeepCode's analysis on #a4dedc found:

  • ℹ️ 4 minor issues. 👇
  • ✔️ 4 issues were fixed.

Top issues

Description Example fixes
Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type. Occurrences: 🔧 Example fixes
Don't use 'String' as a type. Use 'string' instead. Occurrences: 🔧 Example fixes
Identifier 'path' is never reassigned; use 'const' instead of 'let'. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@rafaelmakaha rafaelmakaha changed the base branch from master to develop February 2, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Alerts
1 participant