Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make go-lint seems to be ignoring sibling files in folders where there is a go.mod/go.sum file #423

Open
christos-einride opened this issue May 4, 2023 · 1 comment
Labels

Comments

@christos-einride
Copy link

At least in the evolve backend folder, when I run make go-lint, any issue in the .go files that are siblings to go.mod/go.sum files is completely ignored.

Steps to reproduce:

  1. go in the backend folder of the evolve repo
  2. add any .go file in that folder (as long as it is in the same folder with a go.mod/go.sum folder)
  3. type any garbage text you want in it (aka. sleep on your keyboard)
  4. run make go-lint from the same folder (/backend)

linter will report that everything is fine.
What I would expect is that the linter would catch the garbage text.

Extra info:
Having done the above 4 steps, in the same repo, if you actually go into the /gateway folder and run make go-lint in there, this will report the issue. The implementation of the two functions seems to be different.
I would actually expect that linting in the gateway folder would not report any issues in the backend folder.

Couldn't say if this is a sage issue or if we are doing something weird, so I thought of creating an issue here as a first step. :) 🙏

Copy link

github-actions bot commented May 6, 2024

This issue has been open for 365 days with no activity. Marking as stale.

@github-actions github-actions bot added the Stale label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant