You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
check_deadlines — may emit multiple PartititionFaulty, however, since partitions contain sectors this may be acceptable, furthermore, it's used by the on_finalize hook which does not consume "gas" so batching this may not be worth the effort
check_precommited_sectors — may emit multiple SectorSlashed, while it is also called from the on_finalize hook, here the sector is a single unit, so if multiple sectors for a single owner are slashed the same amount of events will be emitted. I think that batching here will help downstream users when consuming events and reduce "spamming" the network, plus the change should be simple enough
The text was updated successfully, but these errors were encountered:
check_deadlines - We should align the events with how a storage provider can recover faulty partitions. In other words, if the storage provider sees an event emitted that relates to them, it should be able to recover with a single extrinsic. The check_deadlines hook does not consume any gas but the extrinsic used for recovery does, if the SP can cover in 1 extrinsic it saves them gas. These events should be batched since recovery can be made in a single extrinsic (excluding proofs) over multiple partitions and sectors.
check_precommited_sectors - I agree with your statement that we should reduce spamming the network with events, making it simpler for users to consume the events.
check_precommited_sectors, sure. check_deadlines - I don't understand the point. Why does partition containining multiple sectors makes it acceptable and not worth the effort?
Market
publish_deals
— fix(market): batch published deals event #579Storage Provider
check_deadlines
— may emit multiplePartititionFaulty
, however, since partitions contain sectors this may be acceptable, furthermore, it's used by theon_finalize
hook which does not consume "gas" so batching this may not be worth the effortcheck_precommited_sectors
— may emit multipleSectorSlashed
, while it is also called from theon_finalize
hook, here the sector is a single unit, so if multiple sectors for a single owner are slashed the same amount of events will be emitted. I think that batching here will help downstream users when consuming events and reduce "spamming" the network, plus the change should be simple enoughThe text was updated successfully, but these errors were encountered: