Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden Exchange Server against malicious actors spamming it with requests #90

Closed
fl0rek opened this issue Oct 4, 2023 · 1 comment
Closed

Comments

@fl0rek
Copy link
Member

fl0rek commented Oct 4, 2023

ExchangeServerHandler spawns new tasks for Store operations for most of the received requests. Investigate ways of mitigating danger of us getting overwhelmed by huge number of requests.

libp2p allows us to limit number of incoming streams negotiating the connection
https://docs.rs/libp2p/latest/libp2p/swarm/struct.SwarmBuilder.html#method.max_negotiating_inbound_streams

for the connected streams we can track the number of in-flight requests and drop the ResponseChannel to close the connection, if we're getting overwhelmed.

@zvolin zvolin added this to the pre - light node in browser milestone Oct 30, 2023
@zvolin zvolin added this to Lumina Oct 30, 2023
@zvolin zvolin moved this to Todo in Lumina Oct 30, 2023
@zvolin zvolin removed this from the pre - light node in browser milestone Nov 13, 2023
@zvolin
Copy link
Member

zvolin commented Oct 4, 2024

this is now not needed as we no longer spawn but put futures in FuturesUnordered. connection limits is separate case tracked in #330

@zvolin zvolin closed this as completed Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Lumina Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants
@fl0rek @zvolin and others