Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement approval log #4

Open
tayler6000 opened this issue Jul 24, 2022 · 5 comments
Open

Implement approval log #4

tayler6000 opened this issue Jul 24, 2022 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@tayler6000
Copy link
Collaborator

To help mitigate issues of misbehaving services/connections with #3, a separate SQLite database will be created that will store a permanent log of every action performed by an account, and an approval log.

The approval log will show every event performed by a user and will give them a chance to approve it if the action was legitimate, or reverse and flag it if it was fraudulent. After an event is approved or flagged it is removed from the approval log, and the approval or flagging is added to the permanent log. Flagging will be raised to an administrator's attention automatically through some means.

@tayler6000 tayler6000 moved this to Todo in ETN MVP Jul 24, 2022
@tayler6000 tayler6000 added the enhancement New feature or request label Jul 25, 2022
@tayler6000 tayler6000 moved this from Todo to In Progress in ETN MVP Jul 29, 2022
@tayler6000 tayler6000 moved this from In Progress to Todo in ETN MVP Jul 29, 2022
@tayler6000 tayler6000 added this to the MVP API milestone Aug 5, 2022
@plexish
Copy link
Collaborator

plexish commented Aug 15, 2022

Will the votes be counted by default until approved?

@tayler6000
Copy link
Collaborator Author

Will the votes be counted by default until approved?

Votes will be effective immediately but can be reversed if flagged in the approval log. If they're approved, nothing will happen except taking it out of the approval log and adding it to the total log.

@mruwnik
Copy link
Contributor

mruwnik commented Feb 27, 2023

why a separate SQLite database, rather than an additional table?

@tayler6000
Copy link
Collaborator Author

I think it was my initial instinct to make it a separate database altogether to make sure that it wasn't susceptible to any SQL injection, and could be a true permanent record only capable of additional rows. Currently, I see no reason why it needs to be its own db and not just a separate table. @plexish do you remember if I/we had a specific reasoning for it being a separate db?

@plexish
Copy link
Collaborator

plexish commented Mar 2, 2023

No relevant memories found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Todo
Development

No branches or pull requests

3 participants