fixed: ... oneof fields only works for the last specified field #171 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
=======================================
Coverage 97.95% 97.95%
=======================================
Files 30 30
Lines 784 784
=======================================
Hits 768 768
Misses 16 16 ☔ View full report in Codecov by Sentry. |
eigenein
added a commit
that referenced
this pull request
Aug 16, 2024
eigenein
added a commit
that referenced
this pull request
Aug 16, 2024
eigenein
added a commit
that referenced
this pull request
Aug 16, 2024
eigenein
reviewed
Aug 16, 2024
| one_of = descriptor.one_of | ||
| if one_of is not None: | ||
| one_of._keep_attribute(self, descriptor.number) | ||
| if descriptor := (value is not None and self.__PROTOBUF_FIELDS_BY_NAME__.get(name)): |
There was a problem hiding this comment.
Thanks for the submission!
There's one major concern here: __PROTOBUF_FIELDS_BY_NAME__ must always contain a descriptor for the name, so calling .get() here might potentially mask a bug.
Also, the value is not None should've been outside the descriptor assignment.
Not to worry, I'll make a new PR and also add a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Pavel, I made a correction for myself, and in my case it worked. The project's tests also passed.