Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize command doExecuteAsync #28

Open
ceres3idoo opened this issue Feb 22, 2019 · 1 comment
Open

Optimize command doExecuteAsync #28

ceres3idoo opened this issue Feb 22, 2019 · 1 comment
Labels
Refactor Refactoring code

Comments

@ceres3idoo
Copy link
Contributor

ceres3idoo commented Feb 22, 2019 •
edited
Loading

📝 Refactor

buildTransactionDraft method should be called one and only one time in doExecuteAsync in each command.

📖 Details

In doExecuteAsync buildTransactionDraft was called 2 times.
The first one before draft flag check and the second one inside the specific service method call.
For istance in WithdrawCommand class buildWithdrawTransactionDraft was called in doExecuteAsync and in withdrawAsyncmethod of tradingWalletService.
@ceres3idoo ceres3idoo added the Refactor Refactoring code label Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ceres3idoo and others