Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel matrix multiplication is broken. #3

Open
eholk opened this issue May 1, 2014 · 1 comment
Open

Parallel matrix multiplication is broken. #3

eholk opened this issue May 1, 2014 · 1 comment
Labels

Comments

@eholk
Copy link
Owner

eholk commented May 1, 2014

It's currently commented out in the benchmarks so the tests keep passing. Here's the error we get:

./build/main
Benchmarking 1200u x 1200u matrices.
Matrix Multiply: 7.01859f64s
Matrix Multiply (blocked): 15.500061f64s
(1200u, 1200u)
task '<main>' failed at 'assertion failed: lhs.num_cols() == rhs.num_rows()', src/SciRust/matrix/par.rs:25

Since the matrices are the correct size when we call mat_mul, but the assertion immediately fails, I has some suspicions this might be a bug in Rust. That's why I didn't fix it for the 0.2/rust-0.10 release.

@eholk eholk added the bug label May 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants
@eholk and others