From c984be65bca3340663b33bf40424cc0834d03e63 Mon Sep 17 00:00:00 2001 From: Michael Ortmann <41313082+michaelortmann@users.noreply.github.com> Date: Sun, 14 Jul 2024 00:10:34 +0200 Subject: [PATCH 1/2] Raise CHANNELLEN to the maximum of 200 chars defined by rfc1459 and used my networks like undernet --- src/eggdrop.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/eggdrop.h b/src/eggdrop.h index c91ae91e2..3f8de5d7f 100644 --- a/src/eggdrop.h +++ b/src/eggdrop.h @@ -49,9 +49,10 @@ * You should leave this at 32 characters and modify nick-len in the * configuration file instead. */ -#define CHANNELLEN 80 /* FIXME see issue #3 and issue #38 and rfc1459 <= 200 */ -#define HANDLEN 32 /* valid values 9->NICKMAX */ -#define NICKMAX 32 /* valid values HANDLEN->32 */ +#define CHANNELLEN 200 /* rfc1459 defines "Channels names are strings [...] + * of length up to 200 characters. */ +#define HANDLEN 32 /* valid values 9->NICKMAX */ +#define NICKMAX 32 /* valid values HANDLEN->32 */ #define USERLEN 10 From 4a4fea369547f8e40f41a59add46c892aa0c1f74 Mon Sep 17 00:00:00 2001 From: Michael Ortmann <41313082+michaelortmann@users.noreply.github.com> Date: Sun, 21 Jul 2024 00:12:44 +0200 Subject: [PATCH 2/2] Finetune comment --- src/botcmd.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/botcmd.c b/src/botcmd.c index 1e14d0999..bf5528c0c 100644 --- a/src/botcmd.c +++ b/src/botcmd.c @@ -341,9 +341,10 @@ static void remote_tell_who(int idx, char *nick, int chan) strncat(s, c->dname, ssize); /* check if we need to trunc, normally only for first chans on the line. - * CHANNELLEN is 80, so we likely won't ever hit this *now*, but if we - * ever change that for some reason (twitch? ircv3 stuff?) this is still - * a good check to have, 'just in case' + * CHANNELLEN is 200 and channel names rarely exceed 50 chars, so we + * likely won't ever hit this *now*, but if we ever change that for some + * reason (twitch? ircv3 stuff?) this is still a good check to have, + * 'just in case' */ if (i > ssize) { unsigned int trunc = 4;