Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more currencies in proposal payments #91

Open
jeisses opened this issue Jul 11, 2022 · 1 comment
Open

Support more currencies in proposal payments #91

jeisses opened this issue Jul 11, 2022 · 1 comment

Comments

@jeisses
Copy link
Member

jeisses commented Jul 11, 2022

Feature

Users should be able to select multiple tokens as payment for their proposal, like NFX or EOS, instead of just EFX.

Description

Effect DAO currently supports 1 currency as payment for a proposal. The smart contract design already supports multiple tokens but for simplicity this has been disabled. In recent DAO calls we discussed the need to allow NFX and EOS to be paid as rewards.

This proposals smart contract will need a small update to enable support for multiple tokens.

A side note on security: it should not cause much problems to allow arbitrary currencies. If someone adds currencies the DAO does not own this should be detected by the UI so people won't vote on it, and the proposal will not be able to execute anyways. There is a small risk of the spent map of the cycle to consume a lot of RAM, but this only gets populated for approved proposals anyways.

Steps

@jeisses
Copy link
Member Author

jeisses commented Jan 5, 2023

This feature can now be accomplished with ATPs. I actually think we can get rid of cycle budgets, proposal rewards, and recycle strategies and replace them with ATPs. We would end up with a more simple and flexible DAO structure. I'll write this out in detail soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant